4.5.0h DST Time Fix Fails.

[zagadka]

Hi All,

Currently I am getting the "Warning: Please upgrade DST Fix using the upgrade in the administration panel" error at the top of the page.

When trying to apply the DST fix in Admin -> Repair -> "Apply Daylight Savings Time Fix" it fails to run, rendering all of the page except the main content area (error messages are off). In the error log I see the error it throws is:

PHP Fatal error:  Using $this when not in object context in /var/www/public_html/crm/modules/Administration/DstFix.php on line 177, referer: index.php?module=Administration&action=DstFix

Line 177 -> 180 in /modules/Administration/DstFix.php is:

            if ( ( $this->db->dbType == 'mysql' ) or ( $this->db->dbType == 'oci8' ) )
                {
                  $field = "CONCAT($table_name.$date,' ', $table_name.$time)";
                } 
  

It needs to be this - as it doesn't appear to be inside and object:

            if ( ( $db->dbType == 'mysql' ) or ( $db->dbType == 'oci8' ) )
                {
                  $field = "CONCAT($table_name.$date,' ', $table_name.$time)";
                } 
  

It then follows through correctly, does it's bit updating the offsets, inserts a row in versions around line 320something when it's done. However, I still get the error.

The record:

mysql> select * from versions where name='DST Fix';
+--------------------------------------+---------+---------------------+---------------------+------------------+------------+---------+--------------+------------+
| id                                   | deleted | date_entered        | date_modified       | modified_user_id | created_by | name    | file_version | db_version |
+--------------------------------------+---------+---------------------+---------------------+------------------+------------+---------+--------------+------------+
| 1db25f05-3a0d-73ec-6e9c-45bd421a0845 |       0 | 2007-01-29 00:42:27 | 2007-01-29 00:42:27 | 1                | 1          | DST Fix | 3.5.1b       | 3.5.1b     |
+--------------------------------------+---------+---------------------+---------------------+------------------+------------+---------+--------------+------------+
1 row in set (0.00 sec)

This is a clean OS, Database and Sugar install.
Mysql 5.0.27
PHP 5.1.6

Any help would be much appreciated!

Regards,
Tim.

EDIT:
Logging out and then logging back in again *appears* to have removed the error message. But the code snippet above should still be looked at.

Cheers,
Tim.