Logic Hook Trouble

[lmiller]

I posted this in the wrong thread, sorry I'm moving it right now


I work for an SEO company, and I'm trying to make a logic hook that will check a checkbox when a value is less than 11. So I made an integer field, made the area 1-100, which is to be the website's ranking on Google(gpos_c), and I made a Checkbox for first page, so we can search for accounts on and off of the first page(lstpage_c)(I used an L in place of a 1). This is what my code is so far, but I'm getting no results at all.
This is my first time doing this without being walked through it, so don't be surprised at simple mistakes

 <?php
$hook_version = 1;
 
$hook_array = Array();
$hook_array['before_save'][] = Array(1, '1stpagehook', 'custom/modules/Account/1stpagehook.php', '1stpagehook', 'convertToProper');
 
?>  

 <?php
 
/*************************************
Project: Hook to sort by 1st page in numerical values
Developer: Lane Miller
Desc: Hook that will modify the field 1st page according to the numerical value in 
 
the Google position field.
The contents of this file are governed by the GNU General Public License (GPL).
A copy of said license is available here: http://www.gnu.org/copyleft/gpl.html
This code is provided AS IS and WITHOUT WARRANTY OF ANY KIND.
 
*************************************/
 
class 1stpagehook{
 
function convertToProper(&$bean, $event, $arguments){
    if ($bean->$gpos_c , '11'){
        $bean->$lstpage_c = "1";
    }
 
}
 
}
 
?>  

[jsagar]

Hi,
try replacing this code :

 if ($bean->gpos_c , '11'){
        $bean->lstpage_c = "1";
    } 
  

hope it helps you.

[lmiller]

I'm not getting any response in the help section, but this is what my code is right now, but I'm still seeing no changes whatsoever

 <?php
 
/*************************************
Project: Hook to sort by 1st page in numerical values
Developer: Lane Miller
Desc: Hook that will modify the field 1st page according to the numerical value in the Google position field.
The contents of this file are governed by the GNU General Public License (GPL).
A copy of said license is available here: http://www.gnu.org/copyleft/gpl.html
This code is provided AS IS and WITHOUT WARRANTY OF ANY KIND.
 
*************************************/
 
class 1stpagehook {
 
function convertToProper(&$bean, $event, $arguments){
    if ($bean->gpos_c < '11'){ 
            $bean->lstpage_c = "1";
}    else{
        $bean->lstpage_c = "0";
}
 
}
 
?>  

 <?php
$hook_version = 1;
 
$hook_array = Array();
$hook_array['before_save'][] = Array(1, '1stpagehook', 'custom/modules/Account/1stpagehook.php', '1stpagehook', 'convertToProper');
 
?>  

why am i getting no changes at all? no matter what i do

[jsagar]

Hi,
logic hook seems good.

$hook_array['before_save'][] = Array(1, '1stpagehook', 'custom/modules/Account/1stpagehook.php', '1stpagehook', 'convertToProper');

can you check that are you in right directory or not.?
because custom/modules/Account/1stpagehook.php
it should be Accounts not Account.

hope it helps you.

[SugarDev.net]

Try rewriting your code to use integers, not strings, by removing the quotes around the numbers.

[lmiller]

So I did have the directory wrong. After editing it, and trying the codes with different sets of quotes, I'm still seeing no changes, even when I comment out the if statement... here is what I have right now

 <?php 

/************************************* 
Project: Hook to sort by 1st page in numerical values 
Developer: Lane Miller 
Desc: Hook that will modify the field 1st page according to the numerical value in the Google position field. 
The contents of this file are governed by the GNU General Public License (GPL). 
A copy of said license is available here: http://www.gnu.org/copyleft/gpl.html 
This code is provided AS IS and WITHOUT WARRANTY OF ANY KIND. 

*************************************/ 

class 1stpagehook { 

function convertToProper(&$bean, $event, $arguments){ 
    if ($bean->gpos_c < 11 ){  
            $bean->lstpage_c = 1 ; 
}    else{ 
        $bean->lstpage_c = 0 ; 
} 

} 

?>  

 <?php
$hook_version = 1;
$hook_array = Array();
$hook_array['before_save'] = Array(1, '1stpagehook', 'custom/modules/Accounts/1stpagehook.php', '1stpagehook', 'convertToProper');

?>  

[SugarDev.net]

Please provide the location of logic_hooks.php.

[lmiller]

/public_html/custom/modules/Accounts

[cs3gallery]

Lets go over your code and change a few things just to make sure zero mistakes are being made.


I would personally change your code to this:

 <?php 

/************************************* 
Project: Hook to sort by 1st page in numerical values 
Developer: Lane Miller 
Desc: Hook that will modify the field 1st page according to the numerical value in the Google position field. 
The contents of this file are governed by the GNU General Public License (GPL). 
A copy of said license is available here: http://www.gnu.org/copyleft/gpl.html 
This code is provided AS IS and WITHOUT WARRANTY OF ANY KIND. 

*************************************/ 

class pagehook { 

function convertProper(&$bean, $event, $arguments) {

//set variables
$google = $bean->gpos_c;
$page = $bean->lstpage_c;

//begin argument 
    if ($google =< "10") {  
            $page = "1"; 
    }else{ 
            $page = "0"; 
  } 

} 

?>  

Give this a try and dont forget to change the logic hook according to the changed names. Please let me know if this works... if not I have a solution that should surely work.

I also know that I did not have to add variables but I like to keep my code as clead and good looking as possible.