Results 1 to 3 of 3

Thread: Coding standards

  1. #1
    agcopley is offline Sugar Community Member
    Join Date
    Nov 2007
    Location
    Santiago, Chile
    Posts
    423

    Default Coding standards

    Hello Sugarfans,
    I just wanted to bring to attention some rather dubious coding practices in Sugar that I have come across.
    The most recent of which has been hiding content based on style display attributes particularly with reference to users and passwords.
    Basically a reasonably computer-literate person can open a firebug-equiped browser, change the display settings inline and modify their security settings and preferences.
    I am starting to see this in multiple places and it is not good practice. The bottom line is if you don't want content to be seen, don't send it to the browser.
    I appreciate that there are circumstances for using this method but surely not where security is concerned.

    Anyone else have an opinion or thoughts about this?

  2. #2
    JeffPGMT Guest

    Default Re: Coding standards

    1. Might this be a better post in Features and/or Developer?
    2. Pet peeves are rampant when things aren't going well...

    a. Personally, I NEVER (well rarely) use queries in my web code, wrapper sProc(s) & params, that way incremental changes to business rules pertaining to the database remain in the database, okay I'm over it now and will look forward to inserting my queries where ever needed in php code, gosh I feel like an outlaw! Just kidding, I'll be using Sugar Logic most of the time.

    b. Better documentation for what works, detailed - so that my grandmother could follow as such...

    Feature overview, objective, uses and general steps; setup a user & role for each type of user then use the duplicate feature for each individual user...bla, blah
    Step 1. Login as an admin...
    Step 2. blah, blah...

    If you're a power admin most likely just the feature overview will be enough being full & complete and you can get on with it; yet if you are new you'll also be able to follow the detailed steps where to click etc.

    Cases in point...

    Me like little: SugarCRM Developer Blog Blog Archive New in Sugar 6.5 – iCal support for Calendar
    "The simpliest usage is to just put the URL on you account page right into the client of choice, as shown below:"

    Choose the appropriate calendar server to Publish to your client calendar.
    ---------------------------------------------------------------------------|
    Calendar Publishing Options:
    ---------------------------------------------------------------------------|
    Publish vCal ... [Click To Copy]
    Publish iCal ... [Click To Copy]
    ...

    Me like more: SugarCRM iCal Patch

  3. #3
    agcopley is offline Sugar Community Member
    Join Date
    Nov 2007
    Location
    Santiago, Chile
    Posts
    423

    Default Re: Coding standards

    Hi JeffPMGT,
    Not really sure what you are talking about but here goes

    1. Might this be a better post in Features and/or Developer? Well, its neither a Feature request or a Developer Tool/Hint so, no it wouldn't.
    2. Pet peeves are rampant when things aren't going well... Its a QA issue and a security issue, but I guess these are pet peeves for some.

Thread Information

Users Browsing this Thread

There are currently 1 users browsing this thread. (0 members and 1 guests)

Similar Threads

  1. PHP Strict Standards error
    By tobydz in forum Help
    Replies: 3
    Last Post: 2012-08-23, 03:29 AM
  2. PHP Strict Standards error in 5.0.0f
    By wcwooldridge in forum Help
    Replies: 3
    Last Post: 2012-05-02, 04:58 AM
  3. Strict Standards Errors with 6.3 CE
    By billsall in forum Installation and Upgrade Help
    Replies: 0
    Last Post: 2011-12-13, 08:36 PM
  4. PHP Strict Standards
    By bsmither in forum Installation and Upgrade Help
    Replies: 2
    Last Post: 2011-12-13, 03:41 AM
  5. Web standards and Sugar
    By CharlieArmor in forum Site feedback
    Replies: 1
    Last Post: 2007-08-14, 03:35 PM

Bookmarks

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •