The DST and TimeDate class

[wagnerbl]

On includes/TimeDate.php line ~46 you have something like this.

     if(isset($user))
        {    
            if($usertimezone = $user->getPreference('timezone')) {//notice just one = here
                    if(empty($timezones[$usertimezone])) {
                        $GLOBALS['log']->fatal('TIMEZONE:NOT DEFINED-'. $usertimezone);
                        $usertimezone = array();
                    } else {
                        $usertimezone = $timezones[$usertimezone];
                    }
            }
        } 
  

is this a bug or no?

[sugarchris]

It's not really a bug. When we built this class, we realized that the fluid nature of time zones, political and otherwise, requires a pretty constant refresh of those values (GMT offsets, DST, etc.).

What this part of the code does is checks the User's TZ against the (maybe) refreshed timezones.php file that is generated from timezone data we receive from outside the app, and then if a change is detected, resets it.