5.0b email adding / validation problem with sugar email system

[Cousteau]

Hi Folks,

After upgrading to 5.0b we found a minor but unpleasing bug in the upgraded sugar email system.

When we add recipient from our crm database to TO, to CC or to BCC fields by clicking to the (TO: ) (CC: ) or (BCC: ) buttons the system does not add valid format email addresses to the mail.

The added format is the following:
Firstname Familyname <firstname.familyname@domain.hu>; Other Recipient <other.recipient@otherdomain.hu>

And when we push send the system pops up an error message, and does not send anything. The error message is as follows:
'Please enter valid email address for To, CC and BCC fields'

Although we can send emails by deleting the everything, except he pure email addresses (i.e. firstname.familyname@domain.hu works fine), but our users had complaints about missing the good usability of this adding feature.

With the previous versions (5.0, and 5.0a) this add function worked perfectly, and was quite convenient for our users.

Are there any idea how to fix this bug?

[Cousteau]

Hi Folks,

We found the buggy file: /include/javascript/sugar_grp1.js

Replacing it with the old one from 5.0a edition is a good temporary workaround to this validation problem.

Cheers
Geza

[sgandhi]

The reason it deoesn't work because there is a semicolon at the end. If you remove it then it works fine. If there is only one email addresss then we don't need semicolon. If there are multiple entries then the email address should be seperated by semicolon but having semicolon at the end of the TO or CC or BCC field doesn't make sense.

Thanks
-Samir

[supportvirtuo]

If you go in /include/javascript/sugar_grp1.js like cousteau said, search for split(,) and change the comma with a ; and everything should work like it used to.

[sgandhi]

Hi Cousteau,
In order to give more flexibilty, I have modified the function isValidEmail's if condition with this new one.

if(!/^\s*[\w.%+\-]+@([A-Z0-9-]+\.)*[A-Z0-9-]+\.[A-Z]{2,4}\s*;\s*?$/i.test(emailArr[i]) &&
!/^[\w\s.%+\-]*<[A-Z0-9._%+\-]+?@([A-Z0-9-]+\.)*[A-Z0-9-]+\.[A-Z]{2,4}>\s*;?\s*$/i.test(emailArr[i]))


-Samir

[markgill]

Hi Cousteau,
In order to give more flexibilty, I have modified the function isValidEmail's if condition with this new one.

if(!/^\s*[\w.%+\-]+@([A-Z0-9-]+\.)*[A-Z0-9-]+\.[A-Z]{2,4}\s*;\s*?$/i.test(emailArr[i]) &&
!/^[\w\s.%+\-]*<[A-Z0-9._%+\-]+?@([A-Z0-9-]+\.)*[A-Z0-9-]+\.[A-Z]{2,4}>\s*;?\s*$/i.test(emailArr[i]))


-Samir

Does this cause an email evaluation error in other records for you? For instance, if one enters an email address in a contact reocrd, do you get an error unless you add brackets around the address like <myaddress@my.domain> ?

Mark

[jjwdesign]

Shouldn't the first semicolon be optional

;?

var emailArr=emailStr.split(';');for(var i=0;i<emailArr.length;i++){if(!/^\s*[\w.%+\-]+@([A-Z0-9-]+\.)*[A-Z0-9-]+\.[A-Z]{2,4}\s*;?\s*$/i.test(emailArr[i]) && !/^[\w\s.%+\-]*<[A-Z0-9._%+\-]+?@([A-Z0-9-]+\.)*[A-Z0-9-]+\.[A-Z]{2,4}>\s*;?\s*$/i.test(emailArr[i]))

Jeff

[JVWay]

What needs to be done after making these or any changes to the .js files. I've tried running repairs but I still have this email validation problem.

Thanks,
JW

[aran01]

Yep I also tried this fix and I still have the same problem.
This email client is well broken. Showed it to some people yesterday and they said they could not work with it.
Problem with this issue and their sigs get malformed also.

[sgandhi]

Hi All,
Here is the fix for that.

var emailArr = emailStr.split(/[,;]/);
for (var i = 0; i < emailArr.length; i++) {
if(!/^\s*[\w.%+\-]+@([A-Z0-9-]+\.)*[A-Z0-9-]+\.[A-Z]{2,4}\s*$/i.test(emailArr[i]) &&
!/^[\w\s.%+\-]*<[A-Z0-9._%+\-]+?@([A-Z0-9-]+\.)*[A-Z0-9-]+\.[A-Z]{2,4}>\s*$/i.test(emailArr[i]))

return false;
}

-Samir