after save logic hook going in nested infinit loop

[tomjack]

I have problem with after save logic hook.
basically i have, relate fields with contact in opporuntiy and accounts

on account edit, when i click save,
following code logic hook will be used to save contact_id_c, contact_id1_c, contact_id2_c of opporunity

function set_contacts_details() {
		
			$this->opportunityObj->contact_id_c = $_REQUEST['contact_id_c'];
			$this->opportunityObj->contact_id1_c = $_REQUEST['contact_id1_c'];
			$this->opportunityObj->contact_id2_c = $_REQUEST['contact_id2_c'];
			$this->opportunityObj->save();
	}

simillarly on opporuntiy edit, when i click save,
following code logic hook will be used to save contact_id_c, contact_id1_c, contact_id2_c of acocunt

function set_contacts_details() {
		
		if (!empty($this->accountObj)) {	
			$this->accountObj->contact_id_c = $_REQUEST['contact_id_c'];
			$this->accountObj->contact_id1_c = $_REQUEST['contact_id1_c'];
			$this->accountObj->contact_id2_c = $_REQUEST['contact_id2_c'];
			$this->accountObj->save();
		}
	}

But when I do save on any of account of opporunity save, this goes in infinite loop i,e, more than 100 nested calls and apache crashes / goes down

any one knows similar issue...what exactly to be done

[eggsurplus]

Check the REQUEST or even the SESSION vars to figure out what triggered the original logic hook. If it's not the originator return so that it doesn't run the logic hook for the child.

[kuske]

1st LAW of all Sugar hackers:

YOU MUST NOT call a save() in an after safe logic hook !!!

If you call a save(), logic hooks for before_safe and after_safe are called.

So you will come in an endless loop.

[eggsurplus]

No way. I disagree. However, you have to be careful to know what's going on behind the scenes. The reason I disagree is that if you don't call the bean's save you'll have to manually mimic any logic hooks for that bean that you need to fire. For example, if you have a hook that attaches a team to a record based on it's parent and you are an account save hook creating a contact automatically you'd want that contact to call the logic hook to attach that team to the contact.

You can prevent loops but you have to know what to look for.

[abhax]

1st LAW of all Sugar hackers:

YOU MUST NOT call a save() in an after safe logic hook !!!

If you call a save(), logic hooks for before_safe and after_safe are called.

So you will come in an endless loop.

Hi,

But whats the solution to stop it from going into loop.
If sum1 is using the after_save and before_save logic hooks on a custom module?

[eitrix]

why are you using after_save logic hook?

better maybe use before_save logic hook, and throw out save function, because you will assign values to fields before everything is saved, and then leave sugar to save it to db

Haven't ever preferred after_save logic hook, and why would you save something, after it has been saved?

[AlexAv]

Hello

Use SESSION or GLOBALS variables

[marklark]

More information about using SESSION and GLOBAL variables to enable the use of logic hooks that may cause other logic hooks to fire would be nice.

Thanks!

[AlexAv]

Something like this

 function logic_hook_func($bean, $event, $arguments) {

  if((isset($_SESSION['check_hook'])) && ($_SESSION['check_hook']=='true'))
  {
     unset($_SESSION['check_hook']);
     //not save
   }else{
     .....
     $_SESSION['check_hook'] = 'true';
     $bean->save();
     //save data
  }


} 
  

[marklark]

Hmmmm... Any idea why the following fails when I call $acct_bean->save() ?

In my Account logic hook (before_save), I have

if ( $_SESSION['inhook'] == 1 ) {

$_SESSION['inhook'] = 0; # un-set the flag
return;

}
else if ( $bean->bank_c != $bean->fetched_row['bank_c'] ) {

# do stuff

}


In my Contact logic hook (also before_save), I have

if ( $give_credit ) {

$_SESSION['inhook'] = 1;

$acct_bean = new Account( );
$acct_bean->retrieve( $bean->account_id );

$acct_bean->bank_c = $acct_bean->fetched_row['bank_c'] + 1;

$acct_bean->save();

}

thanks again!