Amount in opportunities increases on ever save/duplicate

[catnipper]

I can not really imagine it can be a bug, but I noticed in my SugarCRM 5.1.0b CE that every time I edit/save an opportunity the given amount increases by 2 digits (x 100).

Let's give an example:

1. Create new opportunity: Amount = 100,10 [€]
2. Detail view is correct (100,10)
3. List view fails (10.010,00)
4. Values written into the DB are:
opportunities.amount = '100.1'
opportunities.amount_usdollar = '10010'
5. Going back to details view is correct again (100,10)
6. In edit view we get again '100,10' displayed
7. Saving the data without any changes writes the following to the DB:
opportunities.amount = '100.1'
opportunities.amount_usdollar = '10010'

I defined the following for the System Locale Settings:
- Default currency: Euro
- 1000s Separator: '.' (dot)
- Decimal Symbol: ',' (comma)

Sure this has something to do handling the conversion (calculating 'amount_usdollar').
Maybe anybody already got deeper into this???

[mattecosta]

There is a double conversion error in modules/Opportunities/SaveOverload.php
Modify it changing the line :

$focus->amount_usdollar = $currency->convertToDollar(unformat_number ($focus->amount));
into
$focus->amount_usdollar = $currency->convertToDollar($focus->amount);


This solved the problem to me.
This problem only happen if you use decimal and thousands separator different from US standard.

[andopes]

Hi mattecosta

You may search at the bugs.sugarcrm.com and check if there is that bug filed.
You can file a new one if it does not exist and suggest the fix.
If that one already exists you may add a note suggesting the fix.

Great job!

[eggsurplus]

This is scheduled for 5.2.0a: http://www.sugarcrm.com/forums/showp...50&postcount=2

[catnipper]

Thank's a lot,
that's it!

There is a double conversion error in modules/Opportunities/SaveOverload.php
Modify it changing the line :

$focus->amount_usdollar = $currency->convertToDollar(unformat_number ($focus->amount));
into
$focus->amount_usdollar = $currency->convertToDollar($focus->amount);


This solved the problem to me.
This problem only happen if you use decimal and thousands separator different from US standard.