Custom validation based on role

[Snook]

Hi there,

I'm working on Version 4.5.1f

I need to validate a field depending on the user's role. If the user is part on one specific role, this field can contain only one value.

For this, I have add an empty input field which contain the user's role (which is called "other"). (EditView.html)

<input id="user_role" type="hidden" name="user_role" value="{USER_ROLE}">

Which is filled by EditView.php:

 $user_role = $focus->_getUserRole($current_user->id);
$xtpl->assign("USER_ROLE", $user_role); 
  

The _getUserRole() function is define in Account.php:

 function _getUserRole($user_id) {
        $query = "SELECT r.name FROM acl_roles r, acl_roles_users ru WHERE r.id = ru.role_id AND ru.user_id='$user_id' ";
        $result = $this->db->query($query,true," Error filling in additional detail fields: ");
        $row = $this->db->fetchByAssoc($result);
        $user_role = $row['name'];    
        return $user_role;
    } 
  

Then I have add a jQuery listener function on the Save button of the Account form, which check the value of the field I would like to check:

 function validateForm() {
    $("input.saveAccount").click(function () {
        // Check the user role
        if ($("#user_role").val() == "other") {
            // Check the custom validation
            if ($("#city_c").val() != "Boston") {
                alert("You cannot enter a city else then Boston.");
            }
        }
    });
} 
  

So now everything is working fine except that I don't know how to stop the script that save the account ?
When the user click on the save button, an alert message appear, and when the user click on the OK button, I would like to keep the user on the form to allow him to change this specific field and not to save the new account entry.

Thanks for your suggestions.

[andopes]

Hi, Damien Snoeck

Your code looks interesting, but it seems to be non upgrade safe.

You can validate that field using the default sugar validation.

Take a look at the function addToValidateComparison in the script include/javascript/sugar_3.js

You can modify the EditView.php to add a validation to that field based on user role.

In the modules/Users/User.php there is a function which returns true if the user is related to a role and false otherwise: check_role_membership.

Let me know if you need additional information.

Cheers

[Snook]

Thanks andopes,

Your suggestion looks better than my option.
The first step to check the user's role is passed fine, but I have trouble using the function addToValidateComparison().
I think I need to call the javascript.php function but don't know what kind of data are required in this function. I have try something like this:

 require_once('modules/Users/User.php');
require_once('include/javascript/javascript.php');
$check_role = new User();
$javascript2 = new javascript();
if ($check_role->check_role_membership('Other', $user_id = '')) {
    //addToValidateComparison($field, $type, $displayName, $required, $prefix='',$compareTo)
    $javascript2->addToValidateComparison('localite_c', 'varchar', 'Localité', true, $prefix='','Boston');
} 
  

Thanks for your assistance.

[andopes]

Hi, Damien

In the addToValidateComparison(), the javascript check if the field has the same value of compareTo.
The other fields looks great.

Cheers

[Snook]

Muito obrigado andopes for your help.

After many try and inspections with firebug and firephp (thanks to this two awesome addons), I finally found how to use the function addToValidateComparison(). But it's still buggy. Here is how to use it:

In Accounts/EditVIew.php, after: $javascript = new javascript(); and the calls to functions of the javascript's object I add:

 require_once('modules/Users/User.php');
$check_role = new User();
if ($check_role->check_role_membership('Other', $user_id = '')) {
    //addToValidateComparison($field, $type, $displayName, $required, $prefix='',$compareTo)
    $javascript->addToValidateComparison('city_c', 'varchar', 'The city must be Boston', 'true', $prefix='','city_ref_boston');
} 
  

So, true must be between ' ', and the $compareTo must refer to an other field for the comparison ... why not ! So I refer to this field with 'city_ref_boston' and added an empty input field in my form in Accounts/EditView.html:

<td width="30%" valign="top" class="dataField">
  <span sugar='slot124b'>
    <input type='hidden' name='city_ref_boston' id='city_ref_boston' size='35' maxlength='50' value='Boston'>&nbsp;
  </span sugar='slot'>
</td>

In this case, if the user enter each time a value else than "Boston", the error message will appear each time and the form won't be save (what I expect, so that's fine in this case).

But, if the user let the field that need to be checked (city_c) empty, he would have the error message bellow the field. If he try a 2nd time to save the form with an empty value or a value else than "Boston" the form will be saved !!! What I didn't expect it will do.

Any idea how to resolve that ?

Thanks a lot for suggestions.
Damien