Import fails with apostrophe in Account Name

[hkphooey]

I just re-opened an old bug on this subject, but thought I'd mention it here as it might help someone out.

I was just trying to import a CSV file into the contacts module of 5.0.0c. The import stalled (dots stopped appearing across the screen, and I wasn't taken to the Import Successful screen.

I popped open a new window and saw that only 807 of my 1500 contacts had been imported. Looking at the CSV file, I could see that line 808 contained an Account name with an apostrophe.

I removed the apostrophe and was able to import the remainder of the file ... until it found another Account name with an apostrophe in it.

This is a pretty basic bug which was apparently fixed in version 4.2, but has resurfaced a couple of years on. Hope this helps someone and saves them some frustration.

Bug Report
============
Bug Number: 4846
Subject:: Import Contacts
Type:: Defect
Status: Pending
Sugar Edition:: open_source
Product Category:: Import
Found In Release:: 4.0.1c
Targeted Release:: 5.1.0
Priority:: Medium
Resolution: Fixed
Date Entered: 2006-02-27 04:45:29 (GMT)
Date Modified: 2008-02-27 19:10:23 (GMT)
Description:: Try to import a csv file with a compnay name that has an apostrophe in it as in Sportsman's Market and you get an error

[clint]

Are you doing duplicate checks while importing? I found a bug with duplicate checking when there is an apostrophe, but haven't seen the issue when no dup checking takes place.

[clint]

Bug 21693 tracks the issue with dup checking on import incorrectly flagging fields with apostrophes as duplicates. The bug report also contains the fix.

[benk]

I am experiencing the same "apostrophe in Account Name" problem even when not checking for duplicates. So it appears the bug fix mentioned above may not address the total problem. I am using the latest SugarCRM release and patch, version 5.0.0e.

So as of today (May 22, 2008), it appears that this problem persists.

Thanks,
Ben

[clint]

I am experiencing the same "apostrophe in Account Name" problem even when not checking for duplicates. So it appears the bug fix mentioned above may not address the total problem. I am using the latest SugarCRM release and patch, version 5.0.0e.

So as of today (May 22, 2008), it appears that this problem persists.

Thanks,
Ben

It appears that the bug is slated to be fixed in 5.1.0. The fix is listed in the bug report, so you can apply it yourself to your 5.0.0 system.

[forrest]

Is there a different bug for the non-dupe case, because I had to fix it in a different place:

.../modules/Import
$ diff ImportStep4.php*
321,322c321
< $quotedfield = PearDatabase::quote($focus->$field);
< $query = "SELECT id FROM {$defintion['table']} WHERE {$defintion['rname']} = '{$quotedfield}'";
---
> $query = "SELECT id FROM {$defintion['table']} WHERE {$defintion['rname']} = '{$focus->$field}'";


Guess as to how it snuck back in: QA does not use single quotes in their test cases.

[clint]

Is there a different bug for the non-dupe case, because I had to fix it in a different place:

.../modules/Import
$ diff ImportStep4.php*
321,322c321
< $quotedfield = PearDatabase::quote($focus->$field);
< $query = "SELECT id FROM {$defintion['table']} WHERE {$defintion['rname']} = '{$quotedfield}'";
---
> $query = "SELECT id FROM {$defintion['table']} WHERE {$defintion['rname']} = '{$focus->$field}'";


Guess as to how it snuck back in: QA does not use single quotes in their test cases.

Good catch. Will add this to the bug report.

Just to clarify, this would come into play when importing contacts and the corresponding account name has an apostrophe in it's name. Is this the use case you ran into?

[forrest]

Yes, that's correct, the apostrophe had to be in the Account Name column of a Contact being imported.