Problem counting in logic hook

[dekleinemedia]

Hi,

I have the following issue;

I have created a logic_hook for ProjectTask. It increases every time a new projecttask is created.
This works fine, untill i create projecttask '11'.
The counting stocks when its creating a new task above '10'
Taskname '11' will get the same tasknumber '10' see screenshot
Also is my sorting not working propaply see screenshot

In my attachment you will find the logic_hook.
Can someone please tell me what is wrong? I appreciate

thankss

[ros.vol]

Hello,

AS i can see from the sceenshot - sorting is going under varchar type.

You should convert them into the integer type value.

Cheers,

[dekleinemedia]

Hello,

AS i can see from the sceenshot - sorting is going under varchar type.

You should convert them into the integer type value.

Cheers,

Yes, you are correct. It is indead sorting under varchar type. Can you tell me how to convert this into a integer type value?

Many thanks!

[ros.vol]

How did you define Task# in vardefs?

[dekleinemedia]

How did you define Task# in vardefs?

Hi,

These are my fielddefs of task_number

'task_number' => array (
'required' => '1',
'name' => 'task_number',
'vname' => 'LBL_TASK_NUMBER',
'type' => 'varchar',
'massupdate' => 0,
'comments' => '',
'help' => 'tasknumber',
'importable' => 'true',
'duplicate_merge' => 'disabled',
'duplicate_merge_dom_value' => '0',
'audited' => 1,
'reportable' => 0,
'len' => '2',

I know type is 'varchar' but i have read somewhere that type cannot be 'int' otherwise the logic_hook don't work? Is this correct?

Thanks for your help, I appreciate

[SugarDev.net]

Well in that case we should alter the logic hook. This is no way to sort numbers! Change 'varchar' to 'int' and repair.

[dekleinemedia]

Hi,

I have the following issue;

I have created a logic_hook for ProjectTask. It increases every time a new projecttask is created.
This works fine, untill i create projecttask '11'.
The counting stocks when its creating a new task above '10'
Taskname '11' will get the same tasknumber '10' see screenshot
Also is my sorting not working propaply see screenshot

In my attachment you will find the logic_hook.
Can someone please tell me what is wrong? I appreciate

thankss

Hi,
I've changed the vardefs type task_number but I would like to know why the auto-increment stock when it reach '10'. Can someone please help me? Much thankss

[SugarDev.net]

I'm pasting you attached code here for convenience...

 <?php
if(!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');

class add_code {

    const CODE_PREFIX = "";
    const CODE_SUFFIX = "";
    const CODE_SEPARATOR = "";
    const CODE_FIELD = "task_number";
    const CUSTOM_TABLE = "project_task";
    const ADD_DATE = "0";
    const DATE_FORMAT = "y";
    const ZERO_PADDING = 1; //minimum amount of characters desired for the number. ie 4 = 0001, 3 = 001
    const FIRST_NUM = "1"; //default to start with.

    function add_code(&$bean, $event, $arguments)
    {
        require_once('log4php/LoggerManager.php');

        //pattern to detect valid code, designed to detect non padded numbering too.
        $pattern = "/^" . self::CODE_PREFIX . (self::ADD_DATE?"[0-9]{2}":"") . self::CODE_SEPARATOR . "([0-9]+)" . self::CODE_SUFFIX . "$/";

        $GLOBALS['log']->debug("add_code function fired after save.");

        if(!preg_match($pattern, $bean->fetched_row[self::CODE_FIELD])) {

            $db =  DBManagerFactory::getInstance();
            $query = "select " . self::CODE_FIELD . " from " . self::CUSTOM_TABLE . 
                     " where (" . self::CODE_FIELD . " <> '' or " . self::CODE_FIELD . " is not null) order by right(" . self::CODE_FIELD . ", 1) desc limit 1";
    
            $result = $db->query($query, true, 'Error selecting most recent ' . self::CODE_FIELD . ' CODE');
    
            if ($row=$db->fetchByAssoc($result)) {
                $last_code = $row[self::CODE_FIELD];
            } else {
                //no codes exist, generate default - PREFIX CURRENT_YEAR SEPARATOR FIRST_NUM
                $last_code = self::CODE_PREFIX . (self::ADD_DATE?date(self::DATE_FORMAT):"") . self::CODE_SEPARATOR . self::FIRST_NUM . self::SUFFIX;
            }
    
            $GLOBALS['log']->debug("Last Code: " . $last_code);
    
            preg_match($pattern, $last_code, $matches);
            $num=$matches[1];
            $num++;
            $pads = self::ZERO_PADDING - strlen($num);
            $new_code = self::CODE_PREFIX . (self::ADD_DATE?date(self::DATE_FORMAT):"") . self::CODE_SEPARATOR;
    
            //preform the lead padding
            for($i=0; $i < $pads; $i++) {
                $new_code .= "0";
            }

            $new_code .= $num . self::CODE_SUFFIX;

            $GLOBALS['log']->debug("New Code: " . $last_code);
            
            //write to database
            $query = "INSERT INTO " . self::CUSTOM_TABLE . " (id, " . self::CODE_FIELD . ") VALUES ('$bean->id', '$new_code') ON DUPLICATE KEY UPDATE " . self::CODE_FIELD . "='$new_code'";
            $result = $db->query($query, true, 'Error adding ' . self::CODE_PREFIX . ' code');
        } else {
            $GLOBALS['log']->debug("Code Exists...Exiting " . $bean->fetched_row[" . self::CODE_FIELD . "]);        
        }
    }
}

?>  

[dekleinemedia]

Thanks to SugarDev this problem is solved!

See this threat.

[SugarDev.net]

je weet tog :P