Sometimes 2 of a message in Sent Mail list

[rogersugarsugar]

BitRock 4.5.1.e

This doesn't seem to happen for all sent messages, but for some, there are duplicates listed.

The inconsistency is a bit troubling - I'm afraid to delete one of a duplicate in case there's actually only one copy stored, and have the process delete that only copy. ** Okay, I just did a test message, two showed up in Sent Email, I deleted one copy, and both are gone **

Why is this happening? What, exactly, is happening? How should I deal with it?

Thanks.

[swilliams]

Don't know if this is your problem or not, but I was having duplicates if I associated the email to a contact, and then selected that contact to send the email to.

I found an error in modules/Email/Save.php . It was making duplicate entries in email_contact which causes the listview query to return multiple rows for a single email.

The problem is in the section of code below. It is checking against $exContactIds to make sure it doesn't create duplicates. But, $exContactIds is not created until the last code block below.

if(isset($_REQUEST['object_type']) && !empty($_REQUEST['object_type']) && isset($_REQUEST['object_id']) && !empty($_REQUEST['object_id'])) {
    //run linking code only if the object_id has not been linked as part of the contacts above
    $GLOBALS['log']->debug("CESELY".$_REQUEST['object_type']);
    if(!in_array($_REQUEST['object_id'],$exContactIds)){
        $rel = strtolower($_REQUEST['object_type']);
        $focus->load_relationship($rel);
        $focus->$rel->add($_REQUEST['object_id']);
        $GLOBALS['log']->debug("CESELY LOADED".$_REQUEST['object_type']);
    }
}
//// handle legacy parent_id/parent_type relationship calls
elseif(isset($_REQUEST['parent_type']) && !empty($_REQUEST['parent_type']) && isset($_REQUEST['parent_id']) && !empty($_REQUEST['parent_id'])) {
    //run linking code only if the object_id has not been linked as part of the contacts above
    if(!in_array($_REQUEST['parent_id'],$exContactIds)){
        $rel = strtolower($_REQUEST['parent_type']);
        $focus->load_relationship($rel);
        $focus->$rel->add($_REQUEST['parent_id']);
    }
}

////    END RELATIONSHIP LINKING
///////////////////////////////////////////////////////////////////////////////
$focus->save(FALSE);
////	END EMAIL SAVE/SEND SETUP
///////////////////////////////////////////////////////////////////////////////



///////////////////////////////////////////////////////////////////////////////
////	RELATIONSHIP LINKING
$focus->load_relationship('users');
$focus->users->add($current_user->id);

if(!empty($_REQUEST['to_addrs_ids'])) {
	$focus->load_relationship('contacts');
	$exContactIds = explode(';', $_REQUEST['to_addrs_ids']);
	foreach($exContactIds as $contactId) {
		$contactId = trim($contactId);
		$focus->contacts->add($contactId);
	}
}

Change the order to:

if(!empty($_REQUEST['to_addrs_ids'])) {
	$focus->load_relationship('contacts');
	$exContactIds = explode(';', $_REQUEST['to_addrs_ids']);
	foreach($exContactIds as $contactId) {
		$contactId = trim($contactId);
		$focus->contacts->add($contactId);
	}
}

if(isset($_REQUEST['object_type']) && !empty($_REQUEST['object_type']) && isset($_REQUEST['object_id']) && !empty($_REQUEST['object_id'])) {
    //run linking code only if the object_id has not been linked as part of the contacts above
    $GLOBALS['log']->debug("CESELY".$_REQUEST['object_type']);
    if(!in_array($_REQUEST['object_id'],$exContactIds)){
        $rel = strtolower($_REQUEST['object_type']);
        $focus->load_relationship($rel);
        $focus->$rel->add($_REQUEST['object_id']);
        $GLOBALS['log']->debug("CESELY LOADED".$_REQUEST['object_type']);
    }
}
//// handle legacy parent_id/parent_type relationship calls
elseif(isset($_REQUEST['parent_type']) && !empty($_REQUEST['parent_type']) && isset($_REQUEST['parent_id']) && !empty($_REQUEST['parent_id'])) {
    //run linking code only if the object_id has not been linked as part of the contacts above
    if(!in_array($_REQUEST['parent_id'],$exContactIds)){
        $rel = strtolower($_REQUEST['parent_type']);
        $focus->load_relationship($rel);
        $focus->$rel->add($_REQUEST['parent_id']);
    }
}
////    END RELATIONSHIP LINKING
///////////////////////////////////////////////////////////////////////////////
$focus->save(FALSE);
////	END EMAIL SAVE/SEND SETUP
///////////////////////////////////////////////////////////////////////////////



///////////////////////////////////////////////////////////////////////////////
////	RELATIONSHIP LINKING
$focus->load_relationship('users');
$focus->users->add($current_user->id);

Steve

[rogersugarsugar]

If that will correct it, I hope it makes it into an update.

I have also noticed that this is happening with other records, too.

I have no intentions, however, of doing my own code changes, and then losing them at the next update.

(We are doing a 3 month evaluation of SugarCRM, and I'm accumulating an impressive list of concerns :-/ I'm convinced it's time to write my own, after all. Just a simple, consistent infrastructure where everything just works!y)

[monsta]

Further to this, if you save an email to draft and then send, you get four copies in the emails_contacts table!

What versions are you guys running? We're on Version 4.5.1d (Build 1273)

I haven't had time to test the 4.5.1e release yet, does anyone know if this has been fixed in that release?

[rogersugarsugar]

Further to this, if you save an email to draft and then send, you get four copies in the emails_contacts table!

What versions are you guys running? We're on Version 4.5.1d (Build 1273)

I haven't had time to test the 4.5.1e release yet, does anyone know if this has been fixed in that release?

4.5.1e is what I'm using, and where I'm experiencing the problem...

[skeeby]

Double entries only happen when i send an email to a recipient with cc to some other recipient

gg

[swilliams]

Found another case where duplicates can occur.

Select a parent type, in my case Contacts and then a contact from the popup.

Save as Draft.

Edit and Save as Draft again, or send it, it will cause duplicate entries.

It's caused by not having an "alternate_key" entry in (my case) emails_contactsMetaData.php in the indices array. Without that entry, it will not perform a check for duplicates before creating the relationship between emails and contacts.

I added the following to my meta data file:

array( 'name' => 'idx_emails_contacts',
'type' => 'alternate_key',
'fields' => array('email_id','contact_id')
),

Don't forget to go to Admin->Repair->Rebuild Relationships to make any changes take effect.

It should be an issue for any parent that doesn't have the proper entry in their metadata file:
Example: emails_prospectsMetaData.php,emails_opportunitiesM etaData.php, etc...

Steve

[simple]

Hello

We noticed the same problem (4.5.1e). I changed the file modules/Emails/Email.php.

In the function create_list_query()

       if($show_deleted == 0){
                        $where_auto = " emails.deleted=0 ";
                }else if($show_deleted == 1){
                        $where_auto = " emails.deleted=1 ";
                }

changed to:

        if($show_deleted == 0){
                        $where_auto = " emails.deleted=0 and ec.deleted=0";
                }else if($show_deleted == 1){
                        $where_auto = " emails.deleted=1 ";
                }

It worked here.