Multienum search revisited

[kenneth.thorman]

Multi enum search on custom module does not seem to work I looked at the source code include/SearchForm/SearchForm2.php
and find this

if($GLOBALS['db']->dbType != 'mysql' && !empty($this->seed->field_name_map[$field]['isMultiSelect']) && 
$this->seed->field_name_map[$field]['isMultiSelect']) { 
                        // construct the query for multenums
                        // use the 'like' query for all mssql and oracle examples as both custom and OOB multienums are implemented with types that cannot be used with an 'in'
                        $operator = 'custom_enum';
                        $table_name = $this->seed->table_name ;
                        if ($customField)
                            $table_name .= "_cstm" ;
                        $db_field = $table_name . "." . $field;
                        
	                    foreach($parms['value'] as $key => $val) {

	                        if($val != ' ' and $val != '') {
	                               $qVal = $GLOBALS['db']->quote($val);
	                               if (!empty($field_value)) {
	                                   $field_value .= ' or ';
	                               }
	                               $field_value .= "$db_field like '$qVal' or $db_field like '%$qVal^%' or $db_field like '%^$qVal%' or $db_field like '%^$qVal^%'";
	                        }                            
	                    }

there is even a comment regarding using the like syntax but only on Oracle and MSSQL.

I tried changing the top line to this

if(!empty($this->seed->field_name_map[$field]['isMultiSelect']) && $this->seed->field_name_map[$field]['isMultiSelect']) {

and now it seems to work. What is it I am missing here, it seems way to obvious to be a bug? Why has this been commented out for mysql?

Anyone?

Regards
Kenneth Thorman

[SugarDev.net]

it seems way to obvious to be a bug?

I'm not going to say anything here .



Thnx for the submission, I hope this gets any attention!

[kenneth.thorman]

LOL

Well it seems like there should be something that have caused them to write that much extra code to handle mysql as a special case and have all the logic in place to handle it on Oracle and MSSQL?

Clint/Julian any comments?

Regards
Ken

[lougaou]

Weird weird....

[lougaou]

In 5.1.0 they have commented this part:

/*$GLOBALS['db']->dbType != 'mysql' &&*/